node-feature-discovery
node-feature-discovery copied to clipboard
kubernetes-sigs
cpu: advertise AVX10 version
Add new cpuid label "feature.node.kubernetes.io/cpu-cpuid.AVX10_VERSION" that advertises the supported version of AVX10 vector ISA. Correspondingly, the patch adds AVX10_VERSION to the "cpu.cpuid" feature for NodeFeatureRules to consume.
This makes cpu.cpuid on amd64 architecture a "multi-type" feature in that it contains "flags" and potentially also "attributes" (the only cpuid attribute so far is the AVX10_VERSION).
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: marquiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [marquiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | fa2f008d18ededd77ca0f1239abe54ca3f613d8b |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6650708d22775c0008a2a7e0 |
| Deploy Preview | https://deploy-preview-1673--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@marquiz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-node-feature-discovery-verify-master | 311eaf80c5d8ebbc88e3fd317963f44dd256d4d0 | link | true | /test pull-node-feature-discovery-verify-master |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ArangoGutierrez, marquiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ArangoGutierrez,marquiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.
Project coverage is 39.54%. Comparing base (
814255b) to head (fa2f008).
Additional details and impacted files
@@ Coverage Diff @@
## master #1673 +/- ##
==========================================
- Coverage 39.60% 39.54% -0.07%
==========================================
Files 80 80
Lines 7141 7152 +11
==========================================
Hits 2828 2828
- Misses 4054 4064 +10
- Partials 259 260 +1
| Files | Coverage Ξ | |
|---|---|---|
| source/cpu/cpu.go | 26.53% <0.00%> (-0.56%) |
:arrow_down: |
| source/cpu/cpuid_amd64.go | 0.00% <0.00%> (ΓΈ) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}