node-feature-discovery
node-feature-discovery copied to clipboard
kubernetes-sigs
[WIP] Feat integrate spiffe
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: TessaIO Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | 520dd72d6fc97a1629192b864af345278582ef07 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6641180c9e9c520008910841 |
| Deploy Preview | https://deploy-preview-1663--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Attention: Patch coverage is 22.78481% with 122 lines in your changes are missing coverage. Please review.
Project coverage is 39.32%. Comparing base (
bb36c21) to head (aee2686). Report is 14 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
- Coverage 39.71% 39.32% -0.40%
==========================================
Files 80 81 +1
Lines 6841 6998 +157
==========================================
+ Hits 2717 2752 +35
- Misses 3864 3976 +112
- Partials 260 270 +10
| Files | Coverage Δ | |
|---|---|---|
| cmd/nfd-worker/main.go | 53.91% <50.00%> (-0.15%) |
:arrow_down: |
| cmd/nfd-master/main.go | 0.00% <0.00%> (ø) |
|
| pkg/nfd-master/nfd-master.go | 39.78% <12.19%> (-1.24%) |
:arrow_down: |
| pkg/nfd-worker/nfd-worker.go | 49.29% <7.31%> (-3.26%) |
:arrow_down: |
| pkg/utils/spiffe/spiffe.go | 38.23% <38.23%> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@TessaIO: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-node-feature-discovery-build-image-cross-generic | 520dd72d6fc97a1629192b864af345278582ef07 | link | true | /test pull-node-feature-discovery-build-image-cross-generic |
| pull-node-feature-discovery-e2e-test-master | 520dd72d6fc97a1629192b864af345278582ef07 | link | true | /test pull-node-feature-discovery-e2e-test-master |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Codecov Report
Attention: Patch coverage is 22.78481% with 122 lines in your changes missing coverage. Please review.
Project coverage is 39.49%. Comparing base (
eef9912) to head (520dd72). Report is 68 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
- Coverage 39.85% 39.49% -0.37%
==========================================
Files 80 81 +1
Lines 6839 6996 +157
==========================================
+ Hits 2726 2763 +37
- Misses 3859 3968 +109
- Partials 254 265 +11
| Files | Coverage Δ | |
|---|---|---|
| cmd/nfd-worker/main.go | 53.91% <50.00%> (-0.15%) |
:arrow_down: |
| cmd/nfd-master/main.go | 0.00% <0.00%> (ø) |
|
| pkg/nfd-master/nfd-master.go | 39.78% <12.19%> (-1.24%) |
:arrow_down: |
| pkg/nfd-worker/nfd-worker.go | 49.64% <7.31%> (-2.91%) |
:arrow_down: |
| pkg/utils/spiffe/spiffe.go | 38.23% <38.23%> (ø) |