node-feature-discovery

node-feature-discovery copied to clipboard

A few tests run unreliably due to timeouts that became to small:

• Increase the timeout in eventuallyNonControlPlaneNodes() to 1 minute
• Increase the timeout in GetNodeTopology() to 2 minutes

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ozhuraki Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	b730a0cc877eb0b57ed865171fe2d92f071e3068
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65fc7f6f82ac1f000857bb2f
😎 Deploy Preview	https://deploy-preview-1636--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

@ozhuraki after the last couple of weeks (with new changes getting into NFD) does the test still fails in your environment? I think this PR should be turned into a BUG repo / Issue, given that we agree on not increasing the test timeouts

@ArangoGutierrez

after the last couple of weeks (with new changes getting into NFD) does the test still fails in your environment?

Occasionally yes. It might be that my environment is slower.

I think this PR should be turned into a BUG repo / Issue, given that we agree on not increasing the test timeouts

Yes, let's do so, closing it now. I will still check, if needed, I will create an issue.