node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

chore/deployment: add resources requests and limits for helm and Kustomize

Open TessaIO opened this issue 1 year ago • 4 comments

Resolves #1616

Note: for the moment all of the resource requests and limits for all components are the same (I don't have full visibility on what is needed especially in prod environments). I'd be happy if you want me to change them.

TessaIO avatar Mar 16 '24 21:03 TessaIO

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit d02414cf61ba2f4e29e44247c92f38555cc3765f
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65fd8757a7181200084f04a0
Deploy Preview https://deploy-preview-1631--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 16 '24 21:03 netlify[bot]

/cc @marquiz @ArangoGutierrez

TessaIO avatar Mar 18 '24 11:03 TessaIO

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 22 '24 14:03 k8s-ci-robot

I would like the LGTM to come from @PiotrProkop on this PR

ArangoGutierrez avatar Apr 02 '24 08:04 ArangoGutierrez

/lgtm

PiotrProkop avatar Apr 02 '24 08:04 PiotrProkop

LGTM label has been added.

Git tree hash: a0f72811fbbd7dec7bbd3d91a65445bb6281c517

k8s-ci-robot avatar Apr 02 '24 08:04 k8s-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.52%. Comparing base (0132544) to head (d02414c). Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
- Coverage   30.91%   30.52%   -0.40%     
==========================================
  Files         102      102              
  Lines        9546     9646     +100     
==========================================
- Hits         2951     2944       -7     
- Misses       6317     6431     +114     
+ Partials      278      271       -7     

see 10 files with indirect coverage changes

codecov[bot] avatar Apr 02 '24 09:04 codecov[bot]