node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

Improved liveness probe for nfd-master

Open marquiz opened this issue 1 year ago • 21 comments

What would you like to be added:

The implementation of the gRPC health server in nfd-master is very simple and naive, in practice only telling that the nfd-master main loop was started and that the program hasn't exited. This could be improved e.g. by including the state of the metrics server, nfd api controller and node updater pool (i.e. healthcheck fails if any of those goes down).

Why is this needed:

More trust on the liveness data.

marquiz avatar Jan 17 '24 16:01 marquiz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 16 '24 16:04 k8s-triage-robot