node-feature-discovery

node-feature-discovery copied to clipboard

What would you like to be added:

Remove the gRPC API that was deprecated in v0.14.0 and replaced by NodeFeature CRD API. This includes code (including all related config and command line options like TLS), tests and documentation.

By our deprecation policy (I think this would fall under the "configuration options") we could do this already in v0.16 if so desired.

Why is this needed:

Drop deprecated feature. Simplify code, tests and documentation.

Tasks:

• [x] Flip the feature gate to GA (#1778)
• [x] Drop the -enable-nodefeature-api flag (#1780)
• [ ] Drop the TLS-related flags (-ca-file, -cert-file, -key-file, -verify-node-name)
• [ ] Helm: drop support for cert-manager
• [ ] Drop the -port flag from nfd-master
• [ ] Drop the -server and -server-name-override flags from nfd-worker
• [ ] Make the NFD API controller perma-on, drop -featurerules-controller and -crd-controller flags
• [ ] Drop the gRPC API (pkg/labeler package)
• [ ] Update developer guide in the docs (running nfd-daemons locally, stand-alone, as described there is not possible anymore)
• [ ] Drop all documentation related to the gRPC API

/assign

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale