ng2-codelab icon indicating copy to clipboard operation
ng2-codelab copied to clipboard

Advanced vertical resizing

Open kirjs opened this issue 8 years ago • 3 comments

I'm pretty happy with the current state of the vertical resizing (adjust to content) except the case when the first file has too many lines.

In that case editing the second file becomes painful.

Solution would be making the first file resizable after certain size?

kirjs avatar Dec 26 '16 18:12 kirjs

I think it makes sense to let user to resize component from the beginning. Once it's resized smaller than the content of the code editor - it wouldn't grow as user adds lines. If it's resized to the size that fits all contents of the editor - it grows again as user adds lines. Let me know if that works.

UmaMoiseenko avatar Dec 26 '16 22:12 UmaMoiseenko

Sounds good for me

kirjs avatar Dec 26 '16 23:12 kirjs

@kirjs since we changed our strategy a little, and now we display one file at a time, it illuminates the need in window size getting bigger as user adds code to the file.

UmaMoiseenko avatar Apr 14 '17 23:04 UmaMoiseenko