WindTerm icon indicating copy to clipboard operation
WindTerm copied to clipboard

icon!icon!!icon!!!图标 图标 图标!!

Open mvpyangxu opened this issue 1 year ago • 31 comments

The product is very good, but the icon is not always satisfactory.

So do you consider changing the icon?

这个app非常棒,就是图标看着有些难受。。。能否考虑换一下图标。。相信会有更多人使用的

mvpyangxu avatar Jan 19 '24 09:01 mvpyangxu

+1,关键mac版本的改图标还不生效 ಥ_ಥ

freeNestor avatar Jan 22 '24 06:01 freeNestor

啊?原来还能改图标的吗。。

mvpyangxu avatar Jan 22 '24 06:01 mvpyangxu

mac上可以改dock或文件的显示图标,但是windterm不行,启动后又变回原来的了

freeNestor avatar Jan 22 '24 07:01 freeNestor

这种问题就是属于 不重要不紧急的问题。按目前软件的开发情况,优先级为0。目前核心功能和已知bug还有很多,作者应该没有多余的精力处理这种不是问题的问题。

GodRuiAn avatar Jan 22 '24 09:01 GodRuiAn

这种问题就是属于 不重要不紧急的问题。按目前软件的开发情况,优先级为0。目前核心功能和已知bug还有很多,作者应该没有多余的精力处理这种不是问题的问题。

你说的也没错。不知道他这个是在开源部分还是闭源部分,如果有其他开发爱好者可以帮忙解决就好了;有时候,一个问题提的人多了,优先级就高了;往往优先级低的可能几分钟解决了,优先级高的一个月解决,看如何权衡用户的感受了

freeNestor avatar Jan 22 '24 10:01 freeNestor

这种问题就是属于 不重要不紧急的问题。按目前软件的开发情况,优先级为0。目前核心功能和已知bug还有很多,作者应该没有多余的精力处理这种不是问题的问题。

你说的也没错。不知道他这个是在开源部分还是闭源部分,如果有其他开发爱好者可以帮忙解决就好了;有时候,一个问题提的人多了,优先级就高了;往往优先级低的可能几分钟解决了,优先级高的一个月解决,看如何权衡用户的感受了

别说一个无关紧要的图标了,就是有人给作者提供了比较完善的汉化文件,只需要替换简中的语言文件就可以的,作者都因为功能还没完成而暂时不接受并入打包文件。

GodRuiAn avatar Jan 22 '24 13:01 GodRuiAn

但是因为这些问题,汉化也好,图标也好,流失潜在用户是得不偿失的啊,可能作者比较佛系吧。

mvpyangxu avatar Jan 23 '24 00:01 mvpyangxu

@freeNestor 算是半开源吧,我看没有PR,其实作者如果能接受的话,我是愿意贡献一些设计上尽量贴合macOS的图标。

mvpyangxu avatar Jan 23 '24 00:01 mvpyangxu

https://github.com/kingToolbox/WindTerm/issues/2089#issuecomment-1905103545

@mvpyangxu, only if those icons match the license of the software, of course. Additionally, ideally they they or it would need to be unique to WindTerm, rather than from an existent generic and public icon-set, for instance.

RokeJulianLockhart avatar Jan 23 '24 01:01 RokeJulianLockhart

@RokeJulianLockhart 😞 Well, maybe it's because on MacOS, I'm used to the fact that most icons have rounded corners, but WindTerm doesn't, so it's a little uncomfortable.

mvpyangxu avatar Jan 23 '24 01:01 mvpyangxu

这个图标我看着已经可以了,建议作者别花精力换这个了

ViCrack avatar Jan 23 '24 02:01 ViCrack

😒

mvpyangxu avatar Jan 23 '24 02:01 mvpyangxu

https://github.com/kingToolbox/WindTerm/issues/2089#issuecomment-1905164529

@ViCrack, can you upload the current icon? I'm unable to check currently.

RokeJulianLockhart avatar Jan 23 '24 02:01 RokeJulianLockhart

#2089 (comment)

@ViCrack, can you upload the current icon? I'm unable to check currently.

image

ViCrack avatar Jan 23 '24 02:01 ViCrack

https://github.com/kingToolbox/WindTerm/issues/2089#issuecomment-1905171521

Thanks, @ViCrack. I consequently agree with @mvpyangxu that a new icon may well be an improvement. However, that icon isn't bad - it almost conforms to most sensible iconographic guidelines. For instance, it remains legible when restricted to colouration of solely #FFFFF and #00000 (for print). More impressively, it remains legible at small scales due to how basic it is. Some rounding could make it suitable for the platforms that would be useful on. It'd just need to be integraded independently into each OS-specific branch of the CI.

RokeJulianLockhart avatar Jan 23 '24 02:01 RokeJulianLockhart

@RokeJulianLockhart @ViCrack It shows this on macOS. image image

mvpyangxu avatar Jan 23 '24 02:01 mvpyangxu

image Personally think this is a very good icon, I also asked the author but did not reply

larkzhang avatar Jan 24 '24 05:01 larkzhang

你这是哪个版本,我的为啥是这样 image

mvpyangxu avatar Jan 24 '24 06:01 mvpyangxu

@larkzhang 你这个就好看多了

mvpyangxu avatar Jan 24 '24 06:01 mvpyangxu

https://github.com/kingToolbox/WindTerm/issues/2089#issuecomment-1907446888

@mvpyangxu, that's because you're allowing macOS to determine how the icons are rendered. The icon maker shouldn't have to manually add backgrounds and shadows to icons – that's the responsibility of the desktop environment (or in AOSP's case, the launcher).

RokeJulianLockhart avatar Jan 24 '24 13:01 RokeJulianLockhart

@RokeJulianLockhart Thank you, so I want to know how to set the icon as above, that is @larkzhang , the background color is white and has rounded corners.

mvpyangxu avatar Jan 25 '24 01:01 mvpyangxu

https://github.com/kingToolbox/WindTerm/issues/2089#issuecomment-1909179141

@mvpyangxu, unfortunately, using the native tools provided by the macOS shell, I don't know of any way to do so except by manually replacing the iconographic file with one with a custom background. However, that is basically what this issue requests anyway. I see no reason why this couldn't be included in the CI as a macOS-specific modification, but I've not the knowledge to do so myself. Either that must be done, you replace the icon manually on your installation, or you utilize a different DE entirely (window manager and shell, for it to be consistent).

RokeJulianLockhart avatar Jan 25 '24 02:01 RokeJulianLockhart

Thank you very much for your patient explanation and answer. I will find another way. Thank you again.

mvpyangxu avatar Jan 25 '24 02:01 mvpyangxu

https://github.com/kingToolbox/WindTerm/issues/2089#issuecomment-1909252091

@mvpyangxu, that really isn't to say we couldn't easily put a custom icon in the CI for macOS only. I just don't know how to.

RokeJulianLockhart avatar Jan 25 '24 13:01 RokeJulianLockhart

Windows创建快捷方式的时候,可以修改图标

taotaoyouyou avatar May 23 '24 00:05 taotaoyouyou

Mac倒是也能修改图标,但是启动之后又会变成原来的

mvpyangxu avatar May 23 '24 01:05 mvpyangxu

我直接用windows自带终端的图标了image

foxhui avatar Jun 27 '24 07:06 foxhui

在Mac上不好使啊 😭

mvpyangxu avatar Jun 27 '24 07:06 mvpyangxu

发现安装之后的 /Applications/WindTerm.app/Contents/MacOS/global/themes/default/images/session.svg 中有一个原本的logo,猜测编辑一下这个 session.svg 替换掉原logo, 可能可以解决 macOS上运行时又变成原来的问题,我尝试了一下,但没成功,不太了解 svg 怎么编辑以及程序中如何调用 svg 里面的内容,哪位了解的可以试试

image

xpsuper avatar Sep 09 '24 07:09 xpsuper

@xpsuper 这个好像是会话窗口的图标,不是app的图标

mvpyangxu avatar Sep 09 '24 07:09 mvpyangxu