njwt icon indicating copy to clipboard operation
njwt copied to clipboard

Obvious Fix: RSA flaky test

Open alesbolka opened this issue 5 years ago • 1 comments

  • Signing algorithm was not set correctly
  • Result of token validation was not checked

Test failed even though the validation was not done properly

alesbolka avatar Aug 07 '20 14:08 alesbolka

@alesbolka - Thanks for the PR!

Okta now maintains this repo, so the contribution rules have updated a bit.

While your changes are fairly small, it would make things easier if you either:

  1. Signed a CLA and emailed it as described here: https://developer.okta.com/cla/ OR
  2. Change the PR title to include "Obvious Fix", showing your agreement to that interpretation

Then we'll forward with this.

Thanks again for the PR, and thanks for dealing with this one-time legal hassle.

swiftone avatar Aug 12 '20 18:08 swiftone