jupyterhub-deploy-docker icon indicating copy to clipboard operation
jupyterhub-deploy-docker copied to clipboard

Published 20 hours ago • verified publisher icon jupyterhub

COPY jupyterhub_config.py to Dockerfile.jupyterhub image

Open dsevero opened this issue 6 years ago • 1 comments

Shouldn't jupyterhub_config.py be copied to the image so it reflects changes made? I was editing my jupyterhub_config.py file and noticed that changes were not reflecting.

dsevero avatar Jul 17 '19 06:07 dsevero

Shouldn't jupyterhub_config.py be copied to the image so it reflects changes made? I was editing my jupyterhub_config.py file and noticed that changes were not reflecting.

No because the hub service uses an image that derives from jupyterhub/jupyterhub-onbuild and that image has an ONBUILD instruction that triggers the copy.

That said, I feel it obfuscate what happens and I would be in favor of your changes if you add

- FROM jupyterhub/jupyterhub-onbuild:$JUPYTERHUB_VERSION
+ FROM jupyterhub/jupyterhub:$JUPYTERHUB_VERSION

in Dockerfile.jupyterhub.

dalg24 avatar Jul 17 '19 07:07 dalg24