jupyterhub-deploy-docker

jupyterhub-deploy-docker copied to clipboard

This repo is currently broken https://discourse.jupyter.org/t/jupyterhub-deploy-docker-maintainer-update/14919

I've rewritten and simplified the repo so it should now work and be easier to maintain. However it might be better to archive this repository, and make this an example under https://github.com/jupyterhub/dockerspawner/tree/main/examples (which are also out of date- we should add some tests there).

What do you think?

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

Been struggling with getting this repo running yesterday and today. Glad I found this PR as works instantly :) Makes sense to me that this should be reviewed/merged by the admin

My only thing would be the PRs should be smaller to more easily follow and merge. There are lots of things introduced in one go. Smaller PRS are easier as incremental improvements.

It is a big PR, but this repo is pretty stale, so I think a big restart to get things back in shape is fine at the moment.

It's a big change.... but it works so I think this is a good place to build upon.

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: