fresh icon indicating copy to clipboard operation
fresh copied to clipboard

Ruby 1.8.7 support?

Open postmodern opened this issue 14 years ago • 5 comments

I noticed that the gemspec requires Ruby >= 1.9. I have only casually browsed through the source-code, but I'm wondering why this is required? Is it even possible to support Ruby 1.8.7?

postmodern avatar Jun 29 '11 19:06 postmodern

Hi, it would be possible. I think the main reason for dropping 1.8 support were the (really useful) named regexes. But it would be much more complicated to express the current behaviour without them.

janlelis avatar Jun 29 '11 20:06 janlelis

I see. Maybe the matching could be written as a pure Ruby String parsing method?

postmodern avatar Jun 29 '11 20:06 postmodern

Would be a nice idea, if well done (could also have slightly other semantics, if more logical). But currently, I haven't got much time or motivation to do it ;)

janlelis avatar Jun 29 '11 22:06 janlelis

I'll take a stab at it. Also started doing minor cleanups (reducing duplicate calls). Pull Request at a later date.

postmodern avatar Jun 29 '11 22:06 postmodern

Cool, thanks :D. I'll be on vacation for the next days, so it might take some time till I can take a look at it.

janlelis avatar Jun 29 '11 23:06 janlelis