terraform-provider-iterative

terraform-provider-iterative copied to clipboard

To my mind, moving the Terraform Provider entry point under ./cmd/tpi makes no sense from a project structure standpoint. Note that this repository is first and foremost a Terraform Provider.

I'd wait to refine leo user experience a bit more and then suggest migrating it to a different module, so it can be easily installed with go install like any other tool, and the iterative_task Terraform Resource can still depend on the underlying packages.

Ok, I've moved tpi back into project root.

Sep 12 '22 11:09 tasdomas

As stated at https://github.com/iterative/terraform-provider-iterative/pull/662#pullrequestreview-1102257207, prematurely separating binaries in the same repository might not add too much value, and it's probably more important to separate the repositories themselves. 🤔

Oct 04 '22 17:10 0x2b3bfa0

I'd argue that the binaries were combined prematurely. And that is causing a bug.

Oct 05 '22 12:10 tasdomas

I'd argue[^1] that whether binaries are combined or not is not the main issue, but trying to shoehorn Terraform HCL on a Cobra & Viper command-line tool was definitely premature (or, rather, something that shouldn't have happened)

[^1]: Although agreeing is a strange way of arguing

Oct 09 '22 03:10 0x2b3bfa0

I don't want to stop this pull request for the sake of perfectionism; it's indeed a step in the right direction, degree more or less 🌏 🌍 🌎

Oct 10 '22 03:10 0x2b3bfa0