llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[SYCL][libdevice] Add __imf_llmax/min, __imf_ullmax/min, __imf_umax/min

Open jinge90 opened this issue 3 years ago • 1 comments

Signed-off-by: jinge90 [email protected]

jinge90 avatar Sep 17 '22 08:09 jinge90

Hi, @intel/dpcpp-tools-reviewers Could you help review this PR? Thanks very much.

jinge90 avatar Sep 22 '22 01:09 jinge90

Hi, @pvchupin Could you take a look at this PR? Thanks very much.

jinge90 avatar Sep 23 '22 02:09 jinge90

Hi @jinge90

Can you please provide a 1-2 line description for this change?

Thanks

asudarsa avatar Sep 23 '22 18:09 asudarsa

Hi @jinge90

Can you please provide a 1-2 line description for this change?

Thanks

These math functions/operations are implemented to match CUDA math functions/operations for SYCL and OpenMP offloading on GPU. Which is part of DSE OKR.

xtian-github avatar Sep 23 '22 18:09 xtian-github

LGTM. Please add tests if possible. Thanks

Hi, @asudarsa The test is here in review: https://github.com/intel/llvm-test-suite/pull/1275

Thanks very much.

jinge90 avatar Sep 24 '22 01:09 jinge90