llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Enable builds on macOS host

Open alexbatashev opened this issue 3 years ago • 6 comments

This patch contains minimal changes to make compiler toolchain builds succeed on macOS:

  • Add stubs for platform-dependent functions
  • Disable level zero plugin for macOS exclusively
  • Fix platform-dependent library names
  • Remove get_device_count_by_type tool (which is unused, and rather than fixing it, removal is much simpler)
  • Add minimal CI in post-commit to prevent build breakages in future

The above changes are far from fully working SYCL on Darwin targets, this patch only fixes toolchain builds, and does not attempt to make the toolchain itself functional.

Fixes #258 Fixes #982

alexbatashev avatar Sep 06 '22 07:09 alexbatashev

Test build logs for CI run should be available here soon: https://github.com/alexbatashev/llvm/runs/8201358091?check_suite_focus=true

alexbatashev avatar Sep 06 '22 07:09 alexbatashev

No idea why clang-format is triggered by a file, that is not changed in this PR

alexbatashev avatar Sep 07 '22 11:09 alexbatashev

No idea why clang-format is triggered by a file, that is not changed in this PR

I suppose it's due to this change: https://github.com/intel/llvm/pull/6652. There is a new way to generate the diff, which I suspect might be the reason of this.

bader avatar Sep 07 '22 11:09 bader

@intel/llvm-reviewers-runtime friendly ping

alexbatashev avatar Sep 08 '22 06:09 alexbatashev

Both fails seem to be true for other PRs/commits. Tracker for hung config: https://github.com/intel/llvm/issues/6732

alexbatashev avatar Sep 08 '22 12:09 alexbatashev

@alexbatashev, could you resolve merge conflicts, please?

bader avatar Sep 22 '22 04:09 bader

@alexbatashev, probably another merge is required. Could you take look at pre-commit failures, please?

bader avatar Sep 27 '22 08:09 bader