llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[SYCL][CUDA][HIP][PI] Fix barrier

Open t4c1 opened this issue 3 years ago • 1 comments

Fixes a bug in barrier implementation in CUDA and HIP plugins that often caused barrier not to work. The new implementation is also faster.

Tests in: https://github.com/intel/llvm-test-suite/pull/1122

t4c1 avatar Jul 29 '22 09:07 t4c1

I think none of these failures are actually related to the changes in this PR.

t4c1 avatar Aug 17 '22 10:08 t4c1

@steffenlarsen @smaslov-intel is this okay to merge now or are there further reviews we should request? I also see there is a failure for the ESIMD job, I assume this is unrelated.

AerialMantis avatar Oct 06 '22 13:10 AerialMantis

ESIMD failures seem to happen on other PRs as well. Lets merge this.

steffenlarsen avatar Oct 06 '22 13:10 steffenlarsen