hext icon indicating copy to clipboard operation
hext copied to clipboard

Consider switching gumbo-parser upstream to codeberg.org/gumbo-parser/gumbo-parser

Open thomastrapp opened this issue 1 year ago • 3 comments

https://github.com/google/gumbo-parser is no longer maintained. Arch has already picked up https://codeberg.org/gumbo-parser/gumbo-parser as the new upstream source.

thomastrapp avatar Apr 25 '24 13:04 thomastrapp

Do you think we need to do any auditing on the new dependency? Willing to help out. Can test on windows + MacOS (intel), as well as linux of course.

brandonrobertz avatar Apr 25 '24 16:04 brandonrobertz

Do you think we need to do any auditing on the new dependency?

I have to do my due diligence and verify that their changes to gumbo-parser make sense to me, before adding the new dependency to the binary releases of hext.

If you want to, you can take a look at codeberg.org/gumbo-parser/gumbo-parser, and if you have any objections, let me know.

Thank you for sticking around @brandonrobertz

thomastrapp avatar Apr 26 '24 09:04 thomastrapp

If you want to, you can take a look at codeberg.org/gumbo-parser/gumbo-parser, and if you have any objections, let me know.

I went through the changeset and they're very reasonable right now. Bugfixes, cleanup and slight modernization stuff. Not a whole lot of code honestly.

brandonrobertz avatar Apr 27 '24 01:04 brandonrobertz