inline-plz icon indicating copy to clipboard operation
inline-plz copied to clipboard

First pass at Swarm interface integration for inline comments

Open wparks opened this issue 7 years ago • 4 comments

wparks avatar Mar 16 '18 17:03 wparks

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6.3/bin/inline-plz", line 11, in <module>
    load_entry_point('inlineplz', 'console_scripts', 'inline-plz')()
  File "/home/travis/build/guykisel/inline-plz/inlineplz/main.py", line 61, in main
    result = inline(args)
  File "/home/travis/build/guykisel/inline-plz/inlineplz/main.py", line 148, in inline
    my_interface = interfaces.INTERFACES[args.interface](args)
  File "/home/travis/build/guykisel/inline-plz/inlineplz/interfaces/github.py", line 63, in __init__
    if branch and not pr:
NameError: name 'branch' is not defined

from the failed CI. i added args.branch earlier today

guykisel avatar Mar 16 '18 21:03 guykisel

the readme still references token:

You'll also need to provide the following either in the command line or via environment variables:

owner: the repo organization/owner
repo: the repo name
token: your auth token (encrypt this, don't put this in plaintext in any public configurations!)
url: the url of your scm host
interface: the type of scm host (such as github)

guykisel avatar Mar 19 '18 17:03 guykisel

looking at the console logs from the last run, although it passed, it doesnt look like it tried to run the github interface:

Parsing of stylint took 0 seconds
Running linter: jsonlint
b'+ [email protected]\nadded 124 packages in 5.157s\n\nnpm WARN deprecated [email protected]: Package no longer supported. Contact [email protected] for more info.\nnpm WARN saveError ENOENT: no such file or directory, open \'/home/travis/build/guykisel/inline-plz/package.json\'\nnpm WARN enoent ENOENT: no such file or directory, open \'/home/travis/build/guykisel/inline-plz/package.json\'\nnpm WARN inline-plz No description\nnpm WARN inline-plz No repository field.\nnpm WARN inline-plz No README data\nnpm WARN inline-plz No license field.\nnpm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):\nnpm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})'
['node_modules/.bin/jsonlint', '-c', '-q']
Installation and running of jsonlint took 5 seconds
Parsing of jsonlint took 0 seconds
675 lint messages found
inline-plz version: 0.26.1
Python version: 3.6.3 (default, Nov 28 2017, 18:47:21) 
[GCC 4.8.4]
Last SHA: 1206f79c7a7ba0c9f5a70db6a857a9a164d6e61e
inline-plz version: 0.26.1
Python version: 3.6.3 (default, Nov 28 2017, 18:47:21) 
[GCC 4.8.4]
inline-plz ran for 40 seconds
inline-plz returned exit code 0

travis_time:end:03584e56:start=1521260769120624562,finish=1521260809879847019,duration=40759222457
[0K
[32;1mThe command "inline-plz --autorun" exited with 0.[0m```

guykisel avatar Mar 19 '18 17:03 guykisel

so i think something might be wrong with the github integration

guykisel avatar Mar 19 '18 17:03 guykisel