plugin-tools icon indicating copy to clipboard operation
plugin-tools copied to clipboard

create-plugin: Adds support for remote docker development of backend plugins and frontend react dev tools

Open briangann opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

This is a first-pass at setting up a remote docker debug environment, we'll iterate on this some to iron out a couple of issues.

This takes a locally built dev image of grafana (until we get them auto-published in the pipeline), and adds golang+mage to the image, and runs supervisord to launch grafana and delve connected to the backend.

Pending Items:

  • [ ] Move backend plugin build inside docker container and supervise a mage build:watch
    • [ ] docker-compose would need to map the git repo to a volume in order to build/rebuild with mage
  • [ ] Modify delve to always kill process on disconnect
  • [ ] Get the gpx_* binary name from src/plugin.json vs having to set env var
  • [ ] Maybe detect from src/plugin.json if backend is supported (and do not try to spawn delve), this can still bem useful for frontend debug tools
  • [ ] Another option - write a small watcher service to respawn dlv with the new PID when process is killed (mage build:watch might be sufficient)
  • [ ] not tested on alpine (yet!)

Which issue(s) this PR fixes:

Fixes #735

Special notes for your reviewer:

briangann avatar Feb 23 '24 16:02 briangann

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged but will not trigger a new release. To trigger a new release add the release label before merging. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

github-actions[bot] avatar Feb 23 '24 16:02 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 02 '24 04:06 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 05 '24 06:06 CLAassistant

This pull request has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 03 '24 04:10 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 2 weeks. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 18 '24 04:10 github-actions[bot]