plugin-tools icon indicating copy to clipboard operation
plugin-tools copied to clipboard

update github workflows

Open sympatheticmoose opened this issue 1 year ago • 1 comments

This is to address inconsistency in our CI and Release workflows so we just have to maintain build-action as well as some security improvements (getting flagged by tooling)

### Tasks
- [ ] Update [ci.yaml](https://github.com/grafana/plugin-tools/blob/main/packages/create-plugin/templates/github/ci/.github/workflows/release.yml) to use https://github.com/grafana/plugin-actions/blob/main/build-plugin/action.yml
- [x] Update [build-action](https://github.com/grafana/plugin-actions/blob/main/build-plugin/action.yml) versions i.e. setup-node -> v4
- [x] Add top level `permissions: read-all` and job level `permissions: contents: write` as appropriate

sympatheticmoose avatar Feb 12 '24 14:02 sympatheticmoose

Created some quick PRs which cover everything except consolidation.

sympatheticmoose avatar Feb 12 '24 15:02 sympatheticmoose

@sympatheticmoose I think we can close this as the remaining task in the list looks to be fixed in this PR?

jackw avatar Nov 29 '24 15:11 jackw

@jackw https://github.com/grafana/plugin-tools/blob/main/packages/create-plugin/templates/github/workflows/ci.yml still seems to not use it?

sympatheticmoose avatar Dec 03 '24 10:12 sympatheticmoose

Have added it to the task list. 👍

Not sure how best to handle adding plugin-actions to ci.yml. Probably needs splitting up cos it has dependencies on other scaffolded workflows.

jackw avatar Dec 03 '24 13:12 jackw