grafonnet Expanding Query Types for creating "Query Result" dashboard variables

Expanding Query Types for creating "Query Result" dashboard variables

Open srikotu opened this issue 1 year ago • 3 comments

This PR expands the queryTypes to create "QueryResult" template variable in Grafana.

Querytype array has been extended to include QueryResult function.

Impact This change will help users to use set dashboard variables of Query Type: Query Result.

Issue: https://github.com/grafana/grafonnet/issues/191 Please review the changes and merge them if everything is in order.

Apr 02 '24 16:04 srikotu

@Duologic @malcolmholmes requesting a review of this PR

Apr 03 '24 01:04 srikotu

@Duologic @malcolmholmes requesting a review of this PR

bump quick set of 👀 please

Apr 30 '24 18:04 srikotu

@Duologic, thank you very much for the review, accepted your suggestion 👍🏼

Tried to run make -B generate 10.4.1 but it seems like the jsonnet commands in scripts/generate.sh are using older options like -c.

Is grafonnet locked down to use an older jsonnet version 🤔 , couldn't find a version reference in the repo.

May 13 '24 21:05 srikotu

It is using the go-version of jsonnet, I think -c is not supported on the C-version.

May 28 '24 10:05 Duologic

superseded by #206

May 28 '24 14:05 Duologic

It is using the go-version of jsonnet, I think -c is not supported on the C-version.

so should the contributing docs be updated accordingly or the Makefile be updated for the docs to be "correct" 🤔

May 28 '24 14:05 srikotu