grafana-ansible-collection

grafana-ansible-collection copied to clipboard

Changed the legacy setting [alerting] to [unified_alerting]. Grafana-server will not start with the legacy setting enabled.

All committers have signed the CLA.

I think it would be good to rename the variable grafana_alerting to grafana_unified_alerting.

I think it would be good to rename the variable grafana_alerting to grafana_unified_alerting.

I agree--for consistency. However, if I'm not mistaken, this is lower level. This is a section header in Grafana.ini so changing variable alone will not fix the error. If version selection allows a numerical version, it might be better to use a tag with a ternary to select the correct section header.

I quite like how the grafana helm chart automatically converts yaml to grafana.ini

Example config: https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L772-L1098 Templating: https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/_config.tpl#L11-L36

grafana.ini:
  alerting:
    enabled: true

becomes

[alerting]
enabled = true

Should be doable for ansible too. Maybe should be a separate issue tho.

Created separate issue #210 for my suggestion above.

I think it would be good to rename the variable grafana_alerting to grafana_unified_alerting.

I agree--for consistency. However, if I'm not mistaken, this is lower level. This is a section header in Grafana.ini so changing variable alone will not fix the error. If version selection allows a numerical version, it might be better to use a tag with a ternary to select the correct section header.

Version selection makes sense for backward compatibility, which I like. Could you implement this and update the PR?