faro-web-sdk icon indicating copy to clipboard operation
faro-web-sdk copied to clipboard

demo - allow user to supply URL or IP when running docker-compose

Open danstadler-pdx opened this issue 2 years ago • 0 comments

Description

It would be great if we could add a user-supplied parameter to docker compose up which would let the user pass in the URL or IP of the host they are running on? That would let the demo fully run on a cloud VM. Right now it seems the collect call is hard-coded to localhost.

Steps to reproduce

Run the demo on a cloud VM Watch the console for the collect calls They are trying to send the data to localhost

Expected behavior

collect calls should be sent to the supplied URL or IP

Actual behavior

collect calls can currently only be sent to localhost (assuming the user doesn't try to hack the code, but just runs docker-compose)

Environment

  • SDK version: latest
  • Device type: Cloud VM
  • Device name: AWS Ubuntu VM
  • OS: Ubuntu
  • Browser: Chrome

Demo

Screen Shot 2023-04-19 at 1 08 22 PM

danstadler-pdx avatar Apr 20 '23 15:04 danstadler-pdx