accompanist icon indicating copy to clipboard operation
accompanist copied to clipboard

Published 20 hours ago • verified publisher icon google

[Pager] View remains scrollable when swipping between pages

Open Doomsdayrs opened this issue 3 years ago • 13 comments

Description As the title describes, this happens specifically with a vertical pager. This also makes it difficult to swap between pages (I presume?), as it becomes a struggle to swipe.

Steps to reproduce Manage to get two pages of webviews stuck in the middle

Expected behavior View does not remain scroll-able & pager completes swipe

Additional context #1063 seems related

Video1 of one of my users doing this. Stuck between two web views.

Doomsdayrs avatar Apr 14 '22 04:04 Doomsdayrs

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 20 '22 03:05 github-actions[bot]

https://github.com/google/accompanist/issues/1127#issuecomment-1132432416

Following instructions here, without the removal of code will show the issue

Doomsdayrs avatar May 20 '22 04:05 Doomsdayrs

This is likely related to how nestedScroll is handled.

Having as stated here, I think this would solve the issue?

Doomsdayrs avatar May 31 '22 16:05 Doomsdayrs

I have attempted to add a connection via NestedScrollConnection & NestedScrollDispatcher

I realized that the functionality does not seem to work well with verticalScroll components. Thus I am now stuck.

Doomsdayrs avatar Jun 02 '22 04:06 Doomsdayrs

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 03 '22 03:07 github-actions[bot]

Bump.

Doomsdayrs avatar Jul 03 '22 03:07 Doomsdayrs

Seems like issue with a WebView similarly to 1127?

andkulikov avatar Jul 20 '22 16:07 andkulikov

Seems like issue with a WebView similarly to 1127?

#1127 is due to the webview not constraining properly, instead just matching the max height possible at any time. Which can lead to an infinite page.

Doomsdayrs avatar Jul 22 '22 21:07 Doomsdayrs

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 22 '22 03:08 github-actions[bot]

Ehm, bump to reopen

Doomsdayrs avatar Aug 27 '22 04:08 Doomsdayrs

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 28 '22 04:09 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 29 '22 03:10 github-actions[bot]

Sigh, bump as still occurs

Doomsdayrs avatar Nov 04 '22 05:11 Doomsdayrs

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Dec 05 '22 03:12 github-actions[bot]

silly github, this is not stale

Doomsdayrs avatar Dec 05 '22 03:12 Doomsdayrs

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 20 '23 03:01 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 07 '23 03:03 github-actions[bot]

Bump, it still occurs

Palloxin avatar May 12 '23 13:05 Palloxin