cleanowners icon indicating copy to clipboard operation
cleanowners copied to clipboard

Add a warning if we are removing all users from CODEOWNERS

Open zkoppert opened this issue 1 year ago • 6 comments

zkoppert avatar Feb 01 '24 18:02 zkoppert

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 13 '24 01:03 github-actions[bot]

I would be happy to see that :)

@zkoppert Any chance that you could contribute such functionality?

electriquo avatar Mar 31 '24 09:03 electriquo

You might wish to examine the codeowners_file_contents_new in https://github.com/github/cleanowners/issues/11 and act.

I suggest to always use the same issue and update/close/reopn it accordingly.

electriquo avatar Mar 31 '24 09:03 electriquo

How would folks like to see this warning? in the command line and dont create a pull request? or should we create the pull request and put the warning in the pull request description so folks dont merge through an empty CODEOWNERS?

zkoppert avatar Apr 02 '24 23:04 zkoppert

In my humble opinion, I believe we should draw inspiration from GitHub's stale-repos project. An organization is likely to run workflows like stale-repos, cleanowners, and others from a single repository, allowing the workflow to examine the entire organization.

For instance, the stale-repos action/workflow could maintain an issue with a list of stale repositories. Similarly, cleanowners could maintain an issue with lists of:

  • Repositories without a CODEOWNERS file
  • Repositories with an empty CODEOWNORS file
  • Links to open PRs created by cleanowners
  • Any other such lists...

By doing so, we can streamline our workflow and ensure that our organization's repositories are well-maintained and up-to-date.

electriquo avatar Apr 03 '24 09:04 electriquo

@electriquo I like that idea! I think I'll add a report and issue creation as well as printing a warning to the terminal during the workflow run.

zkoppert avatar Apr 30 '24 18:04 zkoppert