firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

[Do Not Submit] Online Count

Open wu-hui opened this issue 3 years ago • 13 comments

wu-hui avatar Jun 27 '22 15:06 wu-hui

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateField [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jun 27 '22 15:06 google-oss-bot

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (087083f)Merge (9a46b03)Diff
    aar1.26 MB1.30 MB+46.7 kB (+3.7%)
    apk (aggressive)491 kB493 kB+2.01 kB (+0.4%)
    apk (release)3.39 MB3.40 MB+12.9 kB (+0.4%)

Test Logs

Notes

  • Commit (9a46b03) is created by Prow via merging PR base commit (087083f) and head commit (7f090e2).

google-oss-bot avatar Jun 27 '22 15:06 google-oss-bot

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.01% (087083f) to 44.44% (9a46b03) by -1.57%.

    21 individual files with coverage change

    FilenameBase (087083f)Merge (9a46b03)Diff
    AggregateQuery.java?15.00%?
    AggregateQuerySnapshot.java?0.00%?
    AggregateSource.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    Datastore.java29.76%23.28%-6.49%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.24%36.11%-2.12%
    FirestoreGrpc.java2.62%2.46%-0.15%
    Preconditions.java52.63%57.89%+5.26%
    Query.java3.65%3.97%+0.32%
    RemoteStore.java89.56%88.49%-1.07%
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    SQLitePersistence.java86.34%86.89%+0.55%
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?
    SyncEngine.java93.57%93.27%-0.30%

Test Logs

Notes

  • Commit (9a46b03) is created by Prow via merging PR base commit (087083f) and head commit (7f090e2).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

google-oss-bot avatar Jun 27 '22 15:06 google-oss-bot

Unit Test Results

1 097 tests  +696   1 081 :heavy_check_mark: +682   1m 7s :stopwatch: +34s      79 suites +  52        16 :zzz: +  14       79 files   +  52          0 :x: ±    0 

Results for commit 7f090e26. ± Comparison against base commit 4cec8a4f.

This pull request removes 401 and adds 1097 tests. Note that renamed tests count towards both.
com.google.firebase.database.DataSnapshotTest ‑ basicIterationWorks
com.google.firebase.database.DataSnapshotTest ‑ existsWorks
com.google.firebase.database.DatabaseRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.database.MapperTest ‑ XMLAndURLBean
com.google.firebase.database.MapperTest ‑ allowNullEverywhere
com.google.firebase.database.MapperTest ‑ argConstructorCantBeDeserialized
com.google.firebase.database.MapperTest ‑ beanMapsMustHaveStringKeys
com.google.firebase.database.MapperTest ‑ beanMapsMustHaveStringKeysForSerializing
com.google.firebase.database.MapperTest ‑ beansCanContainBeanLists
com.google.firebase.database.MapperTest ‑ beansCanContainBeanMaps
…
com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
…
This pull request removes 2 skipped tests and adds 16 skipped tests. Note that renamed tests count towards both.
com.google.firebase.database.core.RandomViewProcessorTest ‑ randomOperations
com.google.firebase.database.core.RangeMergeTest ‑ updatingPriorityInChildrenNodeWorksAlone
com.google.firebase.firestore.FirestoreRegistrarTest ‑ storageRegistrar_getComponents_publishesLibVersionComponent
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testDoesNotReplaceResumeTokenWithEmptyByteString
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testHandlesSetMutationThenAckThenTransformThenAckThenTransform
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testIgnoresTargetMappingAfterExistenceFilterMismatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testPersistsResumeTokens
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesFilterDocumentsThatNoLongerMatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeDocumentsFromOtherQueries
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeLocallyModifiedDocuments
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testUsesTargetMappingToExecuteQueries
com.google.firebase.firestore.local.SQLiteLocalStoreTest ‑ testCollectsGarbageAfterAcknowledgedMutation
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 07 '22 17:07 github-actions[bot]

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSource [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 07 '22 17:07 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSource [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 07 '22 18:07 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSource [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 07 '22 19:07 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSource [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 08 '22 18:07 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 20 '22 01:07 google-oss-bot

/test api-information

wu-hui avatar Jul 20 '22 13:07 wu-hui

The public api surface has changed for the subproject firebase-firestore: error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 20 '22 14:07 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 27 '22 15:07 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Aug 15 '22 15:08 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Aug 15 '22 15:08 google-oss-bot

@wu-hui: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 09685a4f8d418e0792b81f754e8a0cddc118cd15 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-bot avatar Aug 15 '22 15:08 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Removed class com.google.firebase.firestore.AggregateQuery [RemovedClass] error: Removed class com.google.firebase.firestore.AggregateQuerySnapshot [RemovedClass] error: Removed class com.google.firebase.firestore.AggregateSource [RemovedClass] error: Removed method com.google.firebase.firestore.Query.count() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Aug 22 '22 01:08 google-oss-bot