firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

DO NOT MERGE: Prototype COUNT using the RunAggregationQuery RPC

Open dconeybe opened this issue 3 years ago • 8 comments

Note: This new RunAggregationQuery RPC is only available in the Firestore emulator (i.e. it's not available in prod). And even the emulator's implementation is experimental. This PR is only for a proof of concept and should not be merged.

dconeybe avatar Jun 04 '22 02:06 dconeybe

The public api surface has changed for the subproject firebase-firestore_ktx: error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod] error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(error.NonExistentClass,String) [AddedMethod] error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(error.NonExistentClass,com.google.firebase.firestore.FieldPath) [AddedMethod] error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod] error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(error.NonExistentClass,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod] error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(error.NonExistentClass,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateField [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSource [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

The public api surface has changed for the subproject firebase-firestore_ktx_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jun 04 '22 02:06 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateField [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass] error: Added class com.google.firebase.firestore.AggregateSource [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jun 04 '22 02:06 google-oss-bot

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.21% (37f0fe7) to 44.64% (03c42d9) by -1.57%.

    18 individual files with coverage change

    FilenameBase (37f0fe7)Merge (03c42d9)Diff
    AggregateField.java?0.00%?
    AggregateQuery.java?0.00%?
    AggregateQuerySnapshot.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    Datastore.java32.14%23.28%-8.87%
    FirestoreClient.java38.24%37.96%-0.28%
    FirestoreGrpc.java2.62%2.46%-0.15%
    PatchMutation.java100.00%98.39%-1.61%
    Query.java3.65%3.64%-0.01%
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    SetMutation.java97.22%94.44%-2.78%
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?

Test Logs

Notes

  • Commit (03c42d9) is created by Prow via merging PR base commit (37f0fe7) and head commit (df05424).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

google-oss-bot avatar Jun 04 '22 02:06 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateField [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jun 04 '22 03:06 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateField [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jun 04 '22 03:06 google-oss-bot

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (37f0fe7)Merge (03c42d9)Diff
    aar1.26 MB1.30 MB+46.1 kB (+3.7%)
    apk (aggressive)489 kB491 kB+2.00 kB (+0.4%)
    apk (release)3.39 MB3.40 MB+7.19 kB (+0.2%)

Test Logs

Notes

  • Commit (03c42d9) is created by Prow via merging PR base commit (37f0fe7) and head commit (df05424).

google-oss-bot avatar Jun 04 '22 03:06 google-oss-bot

The public api surface has changed for the subproject firebase-firestore: error: Added class com.google.firebase.firestore.AggregateField [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass] error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass] error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jun 17 '22 19:06 google-oss-bot

@dconeybe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information df0542401829437838e4869a50b82c8ec93947b4 link /test api-information
device-check-changed df0542401829437838e4869a50b82c8ec93947b4 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-bot avatar Jun 17 '22 19:06 google-oss-bot

This feature was implemented in another PR: #3847. I'm closing this one.

dconeybe avatar Sep 22 '22 05:09 dconeybe