duckdb-rs icon indicating copy to clipboard operation
duckdb-rs copied to clipboard

Organise workspace crates and consolidate Cargo.toml manifest properties/dependencies

Open Swoorup opened this issue 1 year ago • 2 comments

Simplify hacking on this repo by

  • Allowing to change the version from a single Cargo.toml instead of multiple crates.
  • Single place to update external dependency version instead of multiple cargo.toml's

Swoorup avatar Mar 30 '24 06:03 Swoorup

This is def. a good idea, I'll pick this up and solve the conflicts after next release

Maxxen avatar Apr 17 '24 17:04 Maxxen

Sure, I based few more changes, that fixes quite a far bit of the issues with appender (including adding support of union types and works well with nested types) atop this branch. Would be great to have it in. Let me know if anything is needed.

😃

Swoorup avatar May 01 '24 00:05 Swoorup

Well, I am stumped, no clue why there's a bunch of leaks detected by ASAN now.

Maxxen avatar Jun 03 '24 11:06 Maxxen

Ok think I fixed it

Maxxen avatar Jun 03 '24 14:06 Maxxen

Anything preventing this merge btw?

Swoorup avatar Jun 04 '24 10:06 Swoorup

Something silly with the last step of the CI. Working on it.

Maxxen avatar Jun 04 '24 10:06 Maxxen