drizzle-orm icon indicating copy to clipboard operation
drizzle-orm copied to clipboard

feat/make binary and varbinary accept buffer

Open wesleymatosdev opened this issue 2 years ago • 6 comments

  • test: create test allowing buffer use for binary column
  • test: write test enforcing retro compatibility
  • feat: return buffer always for binary type
  • test: update zod tests to work with binary buffer
  • test: update drizzle-valibot tests to work with binary buffer
  • test: update drizzle-typebox tests to work with binary buffer
  • chore: fix mispelling
  • test: create test ensuring varbinary retro compatbility + buffer type
  • feat: make possible to receive buffer on varbinary
  • test: set missing length on varbinary creation
  • test: set varbinary as buffer on typebox, valibot and zod

this is the continuation of the job started on #425. /claim #1188

wesleymatosdev avatar Sep 19 '23 02:09 wesleymatosdev

@AndriiSherman, can you review this? the bounty can be collected only once the PR is merged :smile:

wesleymatosdev avatar Oct 21 '23 02:10 wesleymatosdev

So far looks good to be merged. Can you please sign all the commits so I can merge this PR?

AndriiSherman avatar Jan 05 '24 11:01 AndriiSherman

@ologbonowiwi @AndriiSherman Any updates on this? Anything we can do to help move it along?

tslater avatar Apr 03 '24 19:04 tslater

@tslater is pretty much done on my side.

For precaution, I solved the conflicts. It should be ready to be merged.

wesleymatosdev avatar Apr 03 '24 20:04 wesleymatosdev

any updates?

trim21 avatar Sep 30 '24 10:09 trim21