nginxconfig.io icon indicating copy to clipboard operation
nginxconfig.io copied to clipboard

Husky and lint-staged

Open MrJmpl3 opened this issue 3 years ago • 5 comments

Feature request

Feature description

I think husky and lint-staged can be good to the project

How the feature is useful

Husky and lint-staged prevent commits if some commands fails like eslint or prettier, and maybe can made a standard of the commit message with commitlint

MrJmpl3 avatar Oct 04 '22 03:10 MrJmpl3

👋 I'm not a fan of commit message standards generally, I prefer just having commit names that make sense in the context of what you're doing.

That being said, I'd be down for adding a basic git hook that runs eslint across files being staged.

MattIPv4 avatar Oct 04 '22 11:10 MattIPv4

That can be do it with husky and lint-staged in the pre-commit hook, If you want, I can make a PR with that

PD: Also exists stylelint, It's a linter but for css

MrJmpl3 avatar Oct 04 '22 11:10 MrJmpl3

PD: Also exists stylelint, It's a linter but for CSS

Yah, this project uses it :)

MattIPv4 avatar Oct 04 '22 11:10 MattIPv4

Can you assign this to me? I would love to work on this!

TrendyTomorrow avatar Oct 13 '22 17:10 TrendyTomorrow

Sure @amrittimalsina :)

MattIPv4 avatar Oct 14 '22 00:10 MattIPv4