lisa icon indicating copy to clipboard operation
lisa copied to clipboard

Fix #21 KeyError: 'minopsz'

Open dmknght opened this issue 3 years ago • 3 comments

New version of radare2 changed minopsz and maxopsz to core (old: bin). This commit fixes the task failed when user submit a binary. Cred to @AlbertoFDR for minopsz fix and @xchaoinfo for r2pipe open

dmknght avatar Dec 16 '21 07:12 dmknght

p/s: Tested on my system and LiSa works perfectly with this fix

dmknght avatar Dec 16 '21 07:12 dmknght

Hi, great work, thank you for all your commits. As the pull requests deals with minopsz radare2 issue, I'd rather handle the remaining (pep8, typos, yara) in separate pull request.

danielpoliakov avatar Jan 02 '22 19:01 danielpoliakov

Hi, great work, thank you for all your commits. As the pull requests deals with minopsz radare2 issue, I'd rather handle the remaining (pep8, typos, yara) in separate pull request.

Ooops. I created the PR for the fix only and then i tried working on yara for my personal purpose and all commits were merged to here. Damn let me see if i can remove them

dmknght avatar Jan 04 '22 08:01 dmknght