react-d3-graph icon indicating copy to clipboard operation
react-d3-graph copied to clipboard

Graph looks different with same data

Open vardhan-saniko opened this issue 3 years ago • 3 comments

Describe the bug A clear and concise description of what the bug is.

This is the issue I have raised in stack-overflow. https://stackoverflow.com/questions/72818388/react-d3-graph-renders-differently-for-same-data

I have a component that renders react D3 graph. And I have a switch that displays graph1 when its ON and displays graph2 when its OFF.

Basically there was react conditional rendering based on one variable state.

Issue is: graph1 is appearing differently. When component loads first time, it looks different. When switch is OFF(graph2) and then again ON(graph1), now it looks different. I prefer first graph.

Expected behavior Graph should look the same when there is exactly the same data

Screenshots Screen Shot 2022-06-30 at 8 02 28 AM Screen Shot 2022-06-30 at 8 02 42 AM

Environment:

  • OS: [e.g. iOS] macOS
  • Browser [e.g. chrome, safari] chrome
  • Version [e.g. 22]
  • Node version [e.g. 8.11.0]
  • react-d3-graph version [e.g. 2.0.0-rc2] 2.6.0
  • d3 version [e.g. 5.5.0] 5.16.0
  • react version [e.g. 16.0.0] 18.1.0

vardhan-saniko avatar Jun 30 '22 15:06 vardhan-saniko

Is it resolved?I am also facing same issue

radhakpr avatar Dec 14 '22 15:12 radhakpr

is it resolved ?

Sahilcf avatar Oct 18 '23 21:10 Sahilcf

No, it is not. I found it as a limitation of read-d3-graph. If the state changes and re-renders, the location of nodes are changing.

We should load the graph with a different key whenever re-rendering happens

Ex: <Graph key={this.state.key} >

vardhan-saniko avatar Oct 18 '23 22:10 vardhan-saniko