react-d3-graph icon indicating copy to clipboard operation
react-d3-graph copied to clipboard

Published 20 hours ago • verified publisher icon danielcaldas

Convert x,y to numbers

Open baruchiro opened this issue 3 years ago • 0 comments

Just throwing it here if someone will fork it and will take it to maintain it for all of us.

If you start with the snapshot test in test/graph/graph.snapshot.spec.js, you will see the snapshot is weird. Debug it, and you will see the coordinates are strings. First of all, it is not good.

The bug is in these lines: https://github.com/CheckmarxDev/fusion-react-d3-graph/blob/master/src/components/graph/graph.helper.js#L543

x1 += sourceNodeSize * directionVector.x;
y1 += sourceNodeSize * directionVector.y;

If the x1 and y1 are string, adding a number to them will concatenate the number to the end of the string, and this is why you see coords like 402.6029494893985485,200-4.685309080917388 in the snapshot.

baruchiro avatar Jun 23 '22 08:06 baruchiro