cypress

cypress copied to clipboard

• Closes #27216

Additional details

Though fast-glob 3.3.0 update exposes this error it's a consumer side concern.

The public interface of this package does not support a string as the value for the ignore option since 2018 year (release). I do not consider this issue a bug in my package. It is a problem on the consumer side.

See https://github.com/mrmlnc/fast-glob/issues/404#issuecomment-1624832288 for context

Steps to test

Ran:

yarn workspace @cypress/grep lint
yarn workspace @cypress/grep cy:run

How has the user experience changed?

PR Tasks

• [ n/a ] Have tests been added/updated?
• [ ] Has a PR for user-facing changes been opened in cypress-documentation?
• [ n/a ] Have API changes been updated in the type definitions?

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

@jordanpowell88 @emilyrohrbough could I get eyes on this PR?

@zedconte do you have permissions to re-run checks for me?

@samtsai unfortunately I don't

any chance of getting this PR merged?

fast-glob reverted the breaking change: https://github.com/mrmlnc/fast-glob/releases/tag/3.3.1

This is can probably be closed although it wouldn't hurt either way.

fast-glob reverted the breaking change: https://github.com/mrmlnc/fast-glob/releases/tag/3.3.1

This is can probably be closed although it wouldn't hurt either way.

Probably not, they will reintroduce it in the future

So, in the next major release, we will reintroduce method implementations