cypress-grep
cypress-grep copied to clipboard
feat: make grepFilterSpecs work with negative grep
The updated version of find-test-names outputs full test names, i.e. prepended with the parent suite names. This allows grepFilterSpecs to filter spec files when negative grep matches test but not suite and vice versa.
Benefit: The log is less cluttered, especially with a lot of specs. The speed improvement is minor, about 1.5 seconds per filtered spec file.
Hi @admah could you take a look at this? Or are you waiting until this repo is moved to cypress core?
@Narretz this is on my team's list of upcoming priorities, and isn't dependent on the move. We'll make sure to update this once we've had a chance to review.
Hey @Narretz 👋 . Thanks for creating this PR. I apologize it's taking so long to review this. We are currently in the process of moving this repo to the main cypress repo. As a result we will archive this repo and deprecate the npm package (cypress-grep).
Moving forward though, I would love to add this change in @cyrpess/grep. Would you like to open a PR over for this work over in the main cypress repo? If not, I am happy to do it but didn't want to "steal" your hard work here!