cypress-documentation

cypress-documentation copied to clipboard

This PR should not be merged until we are ready to roll out the final rebrand.

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cypress-documentation	✅ Ready (Inspect)	Visit Preview	Nov 16, 2022 at 9:15PM (UTC)

Remaining items to do:

• [x] Update on.cypress.io/dashboard link to redirect to Cloud (Eng will handle)
• [x] Create on.cypress.io/cloud link and link to cloud.cypress.io (Eng will handle)
• [x] Update content/faq/dashboard-faq.md file name and all references
• [x] Update content/guides/dashboard directory and all references
• [x] Redirects for old dashboard links that are now cloud

@debrisapron I rebased this morning and pulled in your latest changes from Master. I had one conflict with the Cloud Introduction page and cleared that up (your new header banner). Our plan is to merge this PR on 11/16

I was on a PR review for an unrelated issue and realized that if we're renaming all of the existing /dashboard/* URL's to cloud, that we need to add redirects for every renamed file inside of redirects.js so users bookmarking old links get forwarded to the new ones.

I see that you did one indicated below... but I believe every existing /dashboard/* URL needs to be redirected

The redirects file in the PR is here: https://github.com/cypress-io/cypress-documentation/pull/4719/files#diff-0c2a003b2ed5170c245944b00d0738dcfd9ee35f449ffb10252b159c5a457af1

And here is the file directly: https://github.com/cypress-io/cypress-documentation/blob/mvollmer-change-dashboard-to-cloud/redirects.js

You may be able to use like a glob or wildcard pattern to dynamically set the redirects, but worst case you'll just add a manual entry for each one.

@brian-mann I recall this coming up in a conversation months ago and I walked away with the understanding that only the netlify.toml file needed to be updated -- something about the redirects.js file you mentioned not actually doing anything.

https://github.com/cypress-io/cypress-documentation/blob/mvollmer-change-dashboard-to-cloud/netlify.toml

If this is untrue, I'll update redirects.js.

Oh I could be totally wrong about the redirects... I just saw that edited and assumed that's where the functionality is. I didn't look at the netlify.toml so if that's been updated to incorporate this then disregard my review

Edit: I see you did in fact update netlify.toml - presumably you should be able to test this out in the preview environment and know the redirects are working as expected. If that's the case then dismiss my review, you already got everything.