cypress-documentation icon indicating copy to clipboard operation
cypress-documentation copied to clipboard

Broken changelog page

Open robertguss opened this issue 3 years ago • 2 comments

  • fixes the broken changelog page.

robertguss avatar Aug 04 '22 18:08 robertguss

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 6:37PM (UTC)

vercel[bot] avatar Aug 04 '22 18:08 vercel[bot]

@jaffrepaul so I manage to fix the changelog page partially. The issue I cannot figure out is how to sort the changelog orders in desc order so the latest release is first. It looks like we can do it, via these docs, but I cannot figure it out so maybe you or @elylucas can give it a shot.

https://docusaurus.io/docs/sidebar/autogenerated#customize-the-sidebar-items-generator

robertguss avatar Aug 04 '22 18:08 robertguss

@jaffrepaul nice work getting this together! I haven't had a chance to look at the PR yet, but I see 2 things that are different than the current implementation:

  1. We aren't setting an "active" class on the heading being viewed.
  2. We aren't scrolling down far enough. The version number heading is being cut off currently.

This is the current changelog:

Screen Shot 2022-09-20 at 12 47 07 PM

This site:

Screen Shot 2022-09-20 at 1 55 39 PM

admah avatar Sep 20 '22 18:09 admah

@jaffrepaul nice work getting this together! I haven't had a chance to look at the PR yet, but I see 2 things that are different than the current implementation:

  1. We aren't setting an "active" class on the heading being viewed.
  2. We aren't scrolling down far enough. The version number heading is being cut off currently.

This is the current changelog:

Screen Shot 2022-09-20 at 12 47 07 PM

~~This site:~~

~~Screen Shot 2022-09-20 at 1 55 39 PM~~

Cool. I solved the scroll issue. The active class has oddly proven to be difficult since its part of the TOC hack.

jaffrepaul avatar Sep 23 '22 17:09 jaffrepaul