codelab icon indicating copy to clipboard operation
codelab copied to clipboard

Add a fullscreen button to the code examples

Open NothingEverHappens opened this issue 6 years ago • 5 comments

What the issue is about:

On smaller monitors code examples might be too small, so it would be cool to be able to full-screen it.

Mocks

https://codelab.fun/angular/create-first-app/component full screen button

Existing similar functionality

We already have similar functionality for slides preview, so it should be generalized somehow. https://codelab.fun/angular/create-first-app/exercise-bootstrap image

Where to start

We have lots of code example in the app, you can see one here: http://localhost:4200/angular/create-first-app/component

Code-wise this component is responsible for the displaying code examples: https://github.com/codelab-fun/codelab/tree/master/libs/code-demos/src/lib/code-demo component would be a good start

NothingEverHappens avatar Sep 30 '19 10:09 NothingEverHappens

Hey there, I can work on this.

jatinAroraGit avatar Oct 01 '19 05:10 jatinAroraGit

Hey @jatinAroraGit would you like to work on this, or on #1033 (you're assigned already)? The other one seems like a bit easier to start with

NothingEverHappens avatar Oct 01 '19 05:10 NothingEverHappens

I would like to take this up. Is this issue available?

Selnapenek avatar Oct 07 '19 19:10 Selnapenek

I did it. But my wrapper component breaks the layout for the editor with multiple files. I will write when i fix it.

image

Selnapenek avatar Oct 11 '19 00:10 Selnapenek

🔥 Ping me if you need help (feel free to hack something on top of it, we have a big PR coming that would re-do all this layout)

kirjs avatar Oct 11 '19 01:10 kirjs