botium-core icon indicating copy to clipboard operation
botium-core copied to clipboard

Composite Slots throw Undefined Exception during tests

Open birchard opened this issue 1 year ago • 0 comments

Describe the bug I have been working on a Lex V2 project that is using Composite Slots for a few Intents and we found that an undefined exception was interrupting the tests. We found that unfilled subslots were causing the exception when handling the response.

Regular slots get filtered out correctly as they are flat. For example:

"slots": {
  "optInConfirmation": null,
}  

Composite slots have nested subslots, so they are not filtered out:

"slots": {
  "generalInquiry": {
    "subSlots": {
      "optType": null,
      "optQuestion": null
    },
    "shape": "composite",
    "value": {
      "resolvedValues": []
    }
  }
}

To Reproduce Create a composite slot for an intent and test

Expected behavior The behavior should be the same as for simple slots

We have been able to correct the behavior by introducing Option chaining. I have opened a PR with our suggested fix. https://github.com/codeforequity-at/botium-connector-lex/pull/22

Screenshots and Log files If applicable, add screenshots and/or logfiles to help explain your problem.

Botium Flavour:

  • Botium Box ?
  • Botium CLI ?
  • Botium Bindings ?

Botium Version

  • Is there an exact version where this bug is happening ?

Additional context Add any other context about the problem here.

birchard avatar Sep 25 '24 18:09 birchard