terraform-aws-ecs-codepipeline

terraform-aws-ecs-codepipeline copied to clipboard

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature

Code Pipeline source provider GitHub Version 2 is the current preferred GitHub connection, using GitHub Apps rather than OAuth.

Expected Behavior

Support GitHub Version 2 source.

Possibly this is simply a documentation thing, as the existing bitbucket/codestar support might work. Specifically, NOT settings github_oauth_token and settings codestar_connection_arn instead.

Possibly this is simply a documentation thing, as the existing bitbucket/codestar support might work. Specifically, NOT settings github_oauth_token and settings codestar_connection_arn instead.

@ses4j In the context of aws-ecs-web-app, at least, this doesn't seem to be the case. Removing/replacing codepipeline_github_oauth_token with codepipeline_codestar_connection_arn (or codestar_connection_arn) results in pipeline being removed entirely. (Adding it without removing the github_oauth_token results in no applied changes.)

EDIT: After a little bit of poking, I think you're right. The ecs-web-app repo just needs a little tidying. I'll submit a PR.