terraform-aws-ecs-codepipeline icon indicating copy to clipboard operation
terraform-aws-ecs-codepipeline copied to clipboard

Allow CodePipeline to deploy to multiple services at once.

Open gregory opened this issue 5 years ago • 6 comments

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)

This will allow to deploy a build to multiple destinations.

why

  • Provide the justifications for the changes (e.g. business case).

Previously there was a 1-1 mapping between code build & code deploy. Prior to this change, in order to deploy the same image to multiple destinations, one would have to duplicate the CodePipeline module for each deploy destination.

  • Describe why these changes were made (e.g. why do these commits fix the problem?)

I simply allowed to pass multiple service_names as deploy targets.

Screen Shot 2020-09-08 at 18 56 43

gregory avatar Sep 09 '20 01:09 gregory

/test all

gregory avatar Sep 11 '20 17:09 gregory

@SweetOps could you have a look at this one please? :)

gregory avatar Sep 11 '20 17:09 gregory

This pull request is now in conflict. Could you fix it @gregory? 🙏

mergify[bot] avatar Jan 23 '21 15:01 mergify[bot]

/rebuild-readme

joe-niland avatar Apr 21 '21 05:04 joe-niland

Does it take time to merge? My use-case is different from the original, but I want to use this module to just build images and push to ECR, without deploying to the ECS service. I believe this can be achieved with this PR by setting service_names = [].

limitusus avatar Sep 07 '21 08:09 limitusus

Hello!

Since this thread is dead for over half year, I have added the required service_name changes in a separate PR: https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/90.

Could we get the PR#90 approved and merged in order to allow this functionality?

All the kudos to @gregory for making this happen! 🥇

aleksy-zalenski avatar Jan 21 '22 13:01 aleksy-zalenski