guides icon indicating copy to clipboard operation
guides copied to clipboard

JS Guide: Add prettier/eslint editor instructions

Open calebeby opened this issue 7 years ago • 10 comments

I want to add a guide that tells you how to set up Prettier and ESLint in VSCode and maybe other editors. Would it be better to do it in this repo or in https://github.com/cloudfour/eslint-config?

calebeby avatar Jul 12 '18 18:07 calebeby

I love this and great question @calebeby!

More questions that come to mind. If I were a user that wanted to install/use @cloudfour/eslint-config, do I care/want instructions for only how to set up in the codebase? Is the expectation that I also get details on how to set it up in an editor?

It feels as though I don't expect to have instructions on how to add these tools in my editor. But that's not to say I wouldn't appreciate it. Hmm...dilemna. 🤔

Either way, I love the idea and I don't think you should let this be a blocker.

If I had to choose right now, I'd choose to add something to this repo. Reason being, regardless of which eslint config I choose to use (maybe there's a client project where we don't use @cloudfour/eslint-config), I can reference these guides here to configure my editor and it doesn't have to be specific to @cloudfour/eslint-config.

@cloudfour/dev @cloudfour/design Any thoughts?

gerardo-rodriguez avatar Jul 12 '18 21:07 gerardo-rodriguez

Yeah @gerardo-rodriguez that seems reasonable.

calebeby avatar Jul 12 '18 21:07 calebeby

Blarg...now I'm backing up on my original feeling.

But that's not to say I wouldn't appreciate it.

Now I'm feeling, if someone uses @cloudfour/eslint-config, they might appreciate an "oh hey, here's how to set these tools up in your editor also". I'm feeling too many feelings. I'm so torn. 🙈 😅

Any thoughts @tylersticka?

gerardo-rodriguez avatar Jul 12 '18 21:07 gerardo-rodriguez

What if I put the guide here but I add a link from the eslint-config README to here?

calebeby avatar Jul 12 '18 21:07 calebeby

Ha! Linking on the interwebs, what a novel idea! I like it! Works for me!

gerardo-rodriguez avatar Jul 12 '18 21:07 gerardo-rodriguez

@calebeby Is this GH issue related to your comment here?

gerardo-rodriguez avatar Nov 07 '18 00:11 gerardo-rodriguez

I think this issue was more related to setting up editors.

calebeby avatar Nov 07 '18 00:11 calebeby

@calebeby this is done, right?

spaceninja avatar Mar 19 '19 21:03 spaceninja

@spaceninja I don't think I ever got around to this.

calebeby avatar Mar 21 '19 20:03 calebeby

@calebeby (facepalm) I just realized I totally misread the title title. This is about adding instructions for using eslint/prettier in your editor, which, yeah, you're right, isn't done.

spaceninja avatar Mar 21 '19 20:03 spaceninja