circleci-docs icon indicating copy to clipboard operation
circleci-docs copied to clipboard

[WIP] Update docker-layer-caching.md

Open sebastian-lerner opened this issue 3 years ago • 4 comments

a really not great job of trying to describe how the new DLC implementation works.

@joshhsoj1902 what sort of things am i missing here that might be critical to call out?

for the docs team, we're replacing how DLC works "under the hood". some details here: https://circleci.atlassian.net/wiki/spaces/ED/pages/6593282057/DLC+on+Machine+Provisioner+MPDLC

we want to make sure our docs are somewhat up to date if customers have questions on the new implementation.

sebastian-lerner avatar Sep 07 '22 14:09 sebastian-lerner

@sebastian-lerner I've gone through and made some styling edits, so let me know if you'd like to wait for Josh to weigh in on the actual info and if anything is missing, etc.

devinmarieb avatar Sep 08 '22 14:09 devinmarieb

still waiting on josh. he's a bit busy with other stuff this week so this will likekly have to wait

sebastian-lerner avatar Sep 08 '22 14:09 sebastian-lerner

@sebastian-lerner I read this over and it looks good to me. The only other thing we could directly say is that the new DLC results in more consistency in build times vs the old model. but that is implied when we say that there are more cache hits.

I can't think of anything else that is worth mentioning

joshhsoj1902 avatar Sep 21 '22 17:09 joshhsoj1902

@devinmarieb now that we have josh's blessing, any thoughts on how this is worded?

sebastian-lerner avatar Sep 21 '22 20:09 sebastian-lerner

@kbatuigas are you gonna merge? i dont think i have those permissions

sebastian-lerner avatar Sep 27 '22 19:09 sebastian-lerner

@kbatuigas are you gonna merge? i dont think i have those permissions

Can do - thanks for the heads up!

kbatuigas avatar Sep 27 '22 19:09 kbatuigas

still waiting on josh. he's a bit busy with other stuff this week so this will likekly have to wait

On Thu, Sep 8, 2022 at 10:29 AM Devin Beliveau @.***> wrote:

@sebastian-lerner https://urldefense.com/v3/__https://github.com/sebastian-lerner__;!!Nhk69END!c2nTkHdb4qaYp_3FNo6FBFy8R9C5EJaZ7mx3prXQfltCn_-6Yo3xy-4ha7iczgodmU1aNmhrbbIvw5lcrtrODLN4vg$ I've gone through and made some styling edits, so let me know if you'd like to wait for Josh to weigh in on the actual info and if anything is missing, etc.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/circleci/circleci-docs/pull/7344*issuecomment-1240797125__;Iw!!Nhk69END!c2nTkHdb4qaYp_3FNo6FBFy8R9C5EJaZ7mx3prXQfltCn_-6Yo3xy-4ha7iczgodmU1aNmhrbbIvw5lcrtqA4ID1Ng$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AUVWFBMXSPNWQYYR2A7V5YTV5HZ4DANCNFSM6AAAAAAQG26QAQ__;!!Nhk69END!c2nTkHdb4qaYp_3FNo6FBFy8R9C5EJaZ7mx3prXQfltCn_-6Yo3xy-4ha7iczgodmU1aNmhrbbIvw5lcrtoEjOguiQ$ . You are receiving this because you were mentioned.Message ID: @.***>

sebastian-lerner avatar Oct 11 '22 07:10 sebastian-lerner