Cristiano Betta
Cristiano Betta
I figured it out. It works quite well if the `` and `` are on seperate lines. I wrote my HTML on one line for testing purposes and it failed....
Here is the failing test case: https://github.com/cbetta/ruby-readability/commit/485f38596af10d68abcc5849d3b5d98039f6493e
Tried that. I made it: ``` ruby bloom_filter = BloomFilter::Native.new(size: lines.count*200, raise: true) ``` and got the same error
So what does `size` mean for the native bloomfilter? Number of items to be added?
e.g. this still doesn't work: ``` ruby bloom_filter = BloomFilter::Native.new size: lines.count*15, raise: true, hashes: 11 ``` which is loosely based on the estimating article
It also doesn't really matter how big I make the size, it dies at item 34195
So yeah, in that case that last bit of code I shared should work
FYI this is the file I'm trying to load into a bloomfilter: http://dl.dropbox.com/u/108772/dictionary_words.list . It's pretty much OS X's `/usr/share/dict/words` with plurals added
@leggetter can we close this now, based on the 2.0 release?
@leggetter ok, I will evaluate!