cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Fix Integration Tests that require MSW server side mocking

Open hariombalhara opened this issue 3 years ago • 13 comments

Screenshot 2022-09-22 at 3 42 50 PM

hariombalhara avatar Sep 22 '22 10:09 hariombalhara

/bounty 20

PeerRich avatar Jun 05 '23 10:06 PeerRich

💎 $20 bounty created by cal 👉 No need to comment asking to work on it. Just open a PR and claim the bounty with /claim #4667 inside the PR 📝 Before proceeding, please make sure you can receive payouts in your country 💵 Payment arrives in your account 2-5 days after the bounty is rewarded 💯 You keep 100% of the bounty award 🙏 Thank you for contributing to calcom/cal.com!

👉 Add a bounty • Share on socials

algora-pbc[bot] avatar Jun 05 '23 10:06 algora-pbc[bot]

I would like to work on this issue, I have some idea about it. /attempt #4667

rajashekarreddyks avatar Jun 05 '23 11:06 rajashekarreddyks

@Rajashekarksreddy Sure please go ahead

hariombalhara avatar Jun 05 '23 11:06 hariombalhara

/attempt #4667

omkarg01 avatar Jul 21 '23 07:07 omkarg01

Note: The user @Rajashekarksreddy is already attempting to complete issue #4667 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Rajashekarksreddy will complete the issue first, and be awarded the bounty. We recommend discussing with @Rajashekarksreddy and potentially collaborating on the same solution versus creating an alternate solution.

algora-pbc[bot] avatar Jul 21 '23 07:07 algora-pbc[bot]

@hariombalhara how to run these test to check what is the result ?

omkarg01 avatar Jul 24 '23 17:07 omkarg01

What do we need to do on this one?

Do we need to set it up MSW, remove it, or change it to a new tool?

wesleymatosdev avatar Sep 13 '23 04:09 wesleymatosdev

We need to be able to mock test third party API endpoints. So, if MSW works, then that's perfect, but there was some issue with MSW due to which we had to disable it. I think @joeauyeung would be working on this, so I would suggest not to focus on this now.

hariombalhara avatar Sep 14 '23 12:09 hariombalhara

Is this issue solved?

ptdatta avatar Nov 06 '23 02:11 ptdatta

Not a priority for me a the moment. So, removing it from milestone.

hariombalhara avatar Nov 07 '23 09:11 hariombalhara

I would love to fix this issue! Will give it a shot.

mak2002 avatar Nov 17 '23 05:11 mak2002

/attempt #4667

We need to be able to mock test third party API endpoints. So, if MSW works, then that's perfect, but there was some issue with MSW due to which we had to disable it. I think @joeauyeung would be working on this, so I would suggest not to focus on this now. @hariombalhara What is the issue with msw? Please describe. Thank you.

Options

webbdays avatar Mar 18 '24 17:03 webbdays

I think we are instead focussing on real testing with third parties instead of mocking the responses.

We have some tests as well now for that flow. So, closing this one.

hariombalhara avatar Apr 30 '24 09:04 hariombalhara