git-hooks.nix icon indicating copy to clipboard operation
git-hooks.nix copied to clipboard

Interop with mkDerivation's checkPhase?

Open edrex opened this issue 2 years ago • 1 comments

Follow-up to https://github.com/cachix/pre-commit-hooks.nix/issues/277#issuecomment-1522513159.

It seems that the best place to configure a make-based project's tests is via mkDerivation's checkPhase.

It's unclear how best to interoperate between pre-commit hooks and checkPhase though. I think I'd like to have package tests run in a pre-commit hook. Maybe also flake checks. pre-commit.check.enable seems backwards IIUC. pre-commit should run flake stuff, not the other way around.

edrex avatar Apr 25 '23 23:04 edrex

pre-commit run -a?

domenkozar avatar Jul 29 '23 11:07 domenkozar