git-hooks.nix icon indicating copy to clipboard operation
git-hooks.nix copied to clipboard

document that this tool intentionaly violates key design decissions of pre-commit

Open RonnyPfannschmidt opened this issue 2 years ago • 0 comments

pre-commit has a few key design decisions to keep users safe

  1. hooks are isolated from the current repo
  2. direct individual pinning control
  3. the pre commit config file is a easy to read and review friendly part of the repository

this tool however shoehorns all of the control and pinning into a new file, makes the pre-commit configuration non-trackable file that cannot even use the normal standard pre-commit hooks anymore

if pre-commit was supposed to be proppery integrated, then it ought to be something that lists flakes/apps for the hooks, but in the pre-commit config file that combines hook locks and cofiguration

RonnyPfannschmidt avatar Feb 15 '23 12:02 RonnyPfannschmidt