Blake Embrey

@donaldpipowitch Fair enough. The original comment didn't make any sense when I read it. The main concern I have (apart from having to add empty files around the place to...

@ajafff That might be a reasonable way to make use of both features in one go, nice! 😄 Would it make sense to make a request to TSLint to make...

@jmlopez-rod Is this related to the issues I'm seeing in `ter-indent` when using it like: ```ts .update( {}, { returnChanges: 'always' } ) ```

> I'm gonna say the rule is complaining on { returnChanges: 'always' } parameter? Yes, sorry - it is. The rule is https://github.com/blakeembrey/tslint-config-standard/blob/6d0d2f5a968e36f7b763188d32f1b019cee85c52/tslint.js#L63-L69.

I saw https://github.com/eslint/eslint/commit/0ad4d33cdcbdd8f879dc60b56a697d727a619fc1 in the diff you pasted which looks relevant here.

There isn’t any `agent` option for the fetch function - only things documented in the README. The agent isn’t supported because popsicle uses HTTP2 where possible by default, which doesn’t...

I fell way behind on this but made good progress this weekend. I've refactored some of the underlying HTTP transport in node.js to accept socket creation asynchronously (mostly in https://github.com/serviejs/popsicle-transport-http/commit/b31ab39b750fbaed579f4205f823831285a6dea7)....

Wow, it sounds like you are working with some legacy systems! Do you mind if I ask what isn't accepting this? Encoding it yourself instead of the internal is very...

Some initial research: It seems other libraries like `request` and `superagent` don't do this - https://github.com/request/request/blob/9f702bf4b5d075035c28eea55dda44d3a0235926/lib/querystring.js and https://github.com/ljharb/qs/blob/8aa9c26f90335b5483a4f456dea9acbada8a881c/lib/utils.js#L86 are the methods that get invoked, neither are handling the space correctly....

Sounds good. I don't think it'll hurt to try and follow the spec though, so I'll check it out.