Python3_Data_Structures

Python3_Data_Structures copied to clipboard

Every operation taking O(n) time in Linked Lists

1

hi, I think there's a difference between your implementation and the theoratical aspect of Linked List. Deletion and Insertion must take `O(n)` time where you are looping in `O(n)` time

deshwalmahesh

Hi, I think the right method in line 204 should be "_delete_node()" because the method self.delete_node() doesn't take a Node object as a parameter. https://github.com/bfaure/Python3_Data_Structures/blob/8ceac35470f6740b7cb25af0ba94622099e3dab7/AVL_Tree/main.py#L204

Castagnna

* Operators '!=' and '==' call the ' __eq__' method of a class which can give unwanted results. * Better way is to use is and is not instead of...

nishant-ingle

Some bugs

3

Your linked_list.lenght has a bug for list of size 1. Also, your get calls length which does an extra O(n) iteration just to check if index is valid.

afarhangi