attachinary icon indicating copy to clipboard operation
attachinary copied to clipboard

Published 20 hours ago • verified publisher icon assembler

Fix for issue #109 - After uploading a video the thumbnail is missing

Open bluengreen opened this issue 9 years ago • 3 comments

Added resource_type to $cloudinary.url call to get correct url for video thumbnails

bluengreen avatar Jan 05 '16 11:01 bluengreen

Hey @bluengreen can we add a small test for this please?

Also, what about squashing these commits?

Thanks!

orlando avatar Jan 05 '16 16:01 orlando

Is there an existing test for that code?

bluengreen avatar Jan 06 '16 20:01 bluengreen

I don't think we have a test for the thumbnail generation. I'll say that is fine add this to https://github.com/assembler/attachinary/blob/master/spec/features/notes_spec.rb.

Also if you can add a bit of context to this PR, I know that cloudinary defaults to resource_type: image, but why we are doing this instead of using resource_type: auto for example.

orlando avatar Jan 06 '16 21:01 orlando